Compare commits

...

24 Commits

Author SHA1 Message Date
khwezi c31dd308a4 Merge pull request 'payments' (#94) from payments into master
Reviewed-on: #94
2026-06-09 21:53:52 +02:00
Khwezi Mngoma 11dfd18a44 Ensured the assembly scanner picks up shared and core components
continuous-integration/drone/pr Build is passing
2026-06-09 21:52:31 +02:00
Khwezi Mngoma e7f02eca9b Refactored Shop services assembly scanner to be more generic 2026-06-09 21:43:47 +02:00
khwezi 787507bed9 Merge pull request 'Added CartService and LocalStorageService (browser)' (#93) from payments into master
Reviewed-on: #93
2026-06-09 09:10:32 +02:00
Khwezi Mngoma 59af9a5406 Added CartService and LocalStorageService (browser)
continuous-integration/drone/pr Build is passing
2026-06-09 09:08:46 +02:00
khwezi 5140da2c6c Merge pull request 'Passing token hint during signout' (#92) from payments into master
Reviewed-on: #92
2026-06-07 14:09:31 +02:00
Khwezi Mngoma 02ff14ccc8 Passing token hint during signout
continuous-integration/drone/pr Build is passing
2026-06-07 14:09:02 +02:00
khwezi 0ad410c64e Merge pull request 'payments' (#91) from payments into master
Reviewed-on: #91
2026-06-07 13:57:15 +02:00
Khwezi Mngoma e193aa7c1c Adopted standard logout flow
continuous-integration/drone/pr Build is running
2026-06-07 13:56:49 +02:00
Khwezi Mngoma 840d4568e2 Refactored logout process 2026-06-07 13:55:20 +02:00
khwezi 6e580ecdf6 Merge pull request 'Added token hint to logout event' (#90) from payments into master
Reviewed-on: #90
2026-06-07 13:12:05 +02:00
Khwezi Mngoma 60095057b7 Added token hint to logout event
continuous-integration/drone/pr Build is passing
2026-06-07 13:11:33 +02:00
khwezi 4c194c1141 Merge pull request 'Added AddSecurityEndpoints login endpoint' (#89) from payments into master
Reviewed-on: #89
2026-06-07 12:00:50 +02:00
Khwezi Mngoma b41136e2c7 Added AddSecurityEndpoints login endpoint
continuous-integration/drone/pr Build is passing
2026-06-07 12:00:07 +02:00
khwezi 41eb4daeb4 Merge pull request 'Refactored AddSecurityEndpoints' (#88) from payments into master
Reviewed-on: #88
2026-06-07 11:09:02 +02:00
Khwezi Mngoma c423f04b42 Refactored AddSecurityEndpoints
continuous-integration/drone/pr Build is passing
2026-06-07 11:08:05 +02:00
khwezi 7fe5f7aef3 Merge pull request 'Refactored client auth method' (#87) from payments into master
Reviewed-on: #87
2026-06-07 10:33:33 +02:00
Khwezi Mngoma a567fc7cd7 Refactored client auth method
continuous-integration/drone/pr Build is passing
2026-06-07 10:30:56 +02:00
khwezi 31254932ae Merge pull request 'Enabled api audience verification' (#86) from payments into master
Reviewed-on: #86
2026-06-06 23:54:13 +02:00
Khwezi Mngoma c53434a578 Enabled api audience verification
continuous-integration/drone/pr Build is passing
2026-06-06 23:53:19 +02:00
khwezi 5a0aae8182 Merge pull request 'Disabled audience verification on jwt tokens' (#85) from payments into master
Reviewed-on: #85
2026-06-06 21:50:48 +02:00
Khwezi Mngoma 3f3e0dbe88 Disabled audience verification on jwt tokens
continuous-integration/drone/pr Build is passing
2026-06-06 21:49:32 +02:00
khwezi 8d8ebffabf Merge pull request 'Removed required scope policy, no longer needed, audience covers the intent' (#84) from payments into master
Reviewed-on: #84
2026-06-06 16:44:52 +02:00
Khwezi Mngoma dc4addb43a Removed required scope policy, no longer needed, audience covers the intent
continuous-integration/drone/pr Build is passing
2026-06-06 16:44:22 +02:00
16 changed files with 305 additions and 52 deletions
@@ -11,7 +11,7 @@
<!-- Quartz Scheduler--> <!-- Quartz Scheduler-->
<ItemGroup> <ItemGroup>
<PackageReference Include="Bogus" Version="35.6.5" /> <PackageReference Include="Bogus" Version="35.6.5" />
<PackageReference Include="Meziantou.Analyzer" Version="3.0.98"> <PackageReference Include="Meziantou.Analyzer" Version="3.0.102">
<PrivateAssets>all</PrivateAssets> <PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference> </PackageReference>
@@ -116,8 +116,8 @@
<!-- Amazon S3 SDK --> <!-- Amazon S3 SDK -->
<ItemGroup> <ItemGroup>
<PackageReference Include="AWSSDK.Extensions.NetCore.Setup" Version="4.0.4.3" /> <PackageReference Include="AWSSDK.Extensions.NetCore.Setup" Version="4.0.4.5" />
<PackageReference Include="AWSSDK.S3" Version="4.0.24" /> <PackageReference Include="AWSSDK.S3" Version="4.0.24.2" />
<ProjectReference Include="..\LiteCharms.Features\LiteCharms.Features.csproj" /> <ProjectReference Include="..\LiteCharms.Features\LiteCharms.Features.csproj" />
<!-- global Usings --> <!-- global Usings -->
@@ -14,7 +14,7 @@ builder.Services.AddScopedFeatureManagement();
builder.Services builder.Services
.AddLogging() .AddLogging()
.AddShopServices() .AddShopServices()
.AddHostedService<ProductsSeederService>() .AddHostedService<ProductsSeederService>()
.AddHostedService<CategorySeederService>() .AddHostedService<CategorySeederService>()
.AddHostedService<CustomerSeederService>() .AddHostedService<CustomerSeederService>()
@@ -1,5 +1,7 @@
using LiteCharms.Features.Extensions; using LiteCharms.Features.Extensions;
using LiteCharms.Features.MidrandBooks.Abstractions;
using LiteCharms.Features.MidrandBooks.Extensions; using LiteCharms.Features.MidrandBooks.Extensions;
using Microsoft.VisualStudio.TestPlatform.TestHost;
namespace LiteCharms.Features.MidrandBooks.Tests.Common; namespace LiteCharms.Features.MidrandBooks.Tests.Common;
@@ -0,0 +1,3 @@
namespace LiteCharms.Features.MidrandBooks.Abstractions;
public interface IMidrandBooks;
@@ -1,4 +1,5 @@
using LiteCharms.Features.Abstractions; using LiteCharms.Features.Abstractions;
using LiteCharms.Features.MidrandBooks.Abstractions;
namespace LiteCharms.Features.MidrandBooks.Extensions; namespace LiteCharms.Features.MidrandBooks.Extensions;
@@ -8,11 +9,15 @@ public static class Shop
{ {
var serviceType = typeof(IService); var serviceType = typeof(IService);
var implementations = Assembly.GetExecutingAssembly().GetTypes() var sharedImplementations = typeof(IFeatures).Assembly.GetTypes()
.Where(t => serviceType.IsAssignableFrom(t) && t.IsClass && !t.IsAbstract); .Where(t => serviceType.IsAssignableFrom(t) && t.IsClass && !t.IsAbstract);
foreach (var implementation in implementations) foreach (var sharedImplementation in sharedImplementations) services.AddScoped(sharedImplementation);
services.AddScoped(implementation);
var coreImplementations = typeof(IMidrandBooks).Assembly.GetTypes()
.Where(t => serviceType.IsAssignableFrom(t) && t.IsClass && !t.IsAbstract);
foreach (var coreImplementation in coreImplementations) services.AddScoped(coreImplementation);
return services; return services;
} }
@@ -32,7 +32,7 @@
<!-- Quartz Scheduler--> <!-- Quartz Scheduler-->
<ItemGroup> <ItemGroup>
<PackageReference Include="Humanizer" Version="3.0.10" /> <PackageReference Include="Humanizer" Version="3.0.10" />
<PackageReference Include="Meziantou.Analyzer" Version="3.0.98"> <PackageReference Include="Meziantou.Analyzer" Version="3.0.102">
<PrivateAssets>all</PrivateAssets> <PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference> </PackageReference>
@@ -136,8 +136,8 @@
<!-- Amazon S3 SDK --> <!-- Amazon S3 SDK -->
<ItemGroup> <ItemGroup>
<PackageReference Include="AWSSDK.Extensions.NetCore.Setup" Version="4.0.4.3" /> <PackageReference Include="AWSSDK.Extensions.NetCore.Setup" Version="4.0.4.5" />
<PackageReference Include="AWSSDK.S3" Version="4.0.24" /> <PackageReference Include="AWSSDK.S3" Version="4.0.24.2" />
<ProjectReference Include="..\LiteCharms.Features\LiteCharms.Features.csproj" /> <ProjectReference Include="..\LiteCharms.Features\LiteCharms.Features.csproj" />
<!-- global Usings --> <!-- global Usings -->
@@ -0,0 +1,128 @@
using LiteCharms.Features.Abstractions;
using LiteCharms.Features.MidrandBooks.Orders.Models;
using LiteCharms.Features.MidrandBooks.Products.Models;
namespace LiteCharms.Features.MidrandBooks.Orders;
public sealed class CartService : IService
{
private Cart cart = new();
public Cart GetCart() => cart;
public void LoadCart(Cart savedCart) => cart = savedCart;
public void AddItem(ProductPrice productPrice)
{
var itemExists = false;
for (var i = 0; i < cart.Items.Count; i++)
{
if (cart.Items[i].Price!.Id == productPrice.Id)
{
cart.Items[i].Quantity++;
cart.Items[i].Amount += productPrice.Amount;
itemExists = true;
break;
}
}
if (!itemExists)
cart.Items.Add(new CartItem
{
Price = productPrice,
Amount = productPrice.Amount,
Quantity = 1,
});
CalculateTotalPrice();
}
public void UpdateQuantity(long productPriceId, int newQuantity)
{
if (newQuantity <= 0)
{
RemoveAllSameItem(productPriceId);
return;
}
for (var i = 0; i < cart.Items.Count; i++)
{
if (cart.Items[i].Price!.Id == productPriceId)
{
var oldQuantity = cart.Items[i].Quantity;
var pricePerUnit = cart.Items[i].Price!.Amount;
cart.Items[i].Quantity = newQuantity;
cart.Items[i].Amount = pricePerUnit * newQuantity;
break;
}
}
CalculateTotalPrice();
}
public void RemoveOneItem(long productPriceId)
{
for (var i = 0; i < cart.Items.Count; i++)
{
if (cart.Items[i].Price!.Id == productPriceId)
{
if (cart.Items[i].Quantity <= 1)
{
cart.Items.RemoveAt(i);
}
else
{
cart.Items[i].Quantity--;
cart.Items[i].Amount -= cart.Items[i].Price!.Amount;
}
break;
}
}
CalculateTotalPrice();
}
public void RemoveAllSameItem(long productPriceId)
{
if (cart.Items.Count == 0) return;
var item = cart.Items.FirstOrDefault(i => i.Price?.Id == productPriceId);
if (item is not null) cart.Items.Remove(item);
CalculateTotalPrice();
}
public void Clear()
{
if(cart.CustomerId is not null || cart.OrderId is not null)
{
cart.TotalPrice = 0;
cart.TotalVat = 0;
cart.Items.Clear();
return;
}
cart = new Cart();
}
public decimal CalculateTotalPrice()
{
if (cart.Items.Count == 0) return 0;
var gross = cart.Items.Sum(i => i.Amount);
if (!cart.IsVatInclusive) cart.TotalVat = gross * cart.VatRate;
cart.TotalPrice = gross + cart.TotalVat;
return cart.TotalPrice;
}
}
@@ -0,0 +1,18 @@
namespace LiteCharms.Features.MidrandBooks.Orders.Models;
public sealed class Cart
{
public long? CustomerId { get; set; }
public long? OrderId { get; set; }
public decimal TotalPrice { get; set; }
public decimal TotalVat { get; set; }
public decimal VatRate { get; set; } = 0.15m;
public bool IsVatInclusive { get; set; } = true;
public IList<CartItem> Items { get; set; } = [];
}
@@ -0,0 +1,12 @@
using LiteCharms.Features.MidrandBooks.Products.Models;
namespace LiteCharms.Features.MidrandBooks.Orders.Models;
public sealed class CartItem
{
public ProductPrice? Price { get; set; }
public long Quantity { get; set; }
public decimal Amount { get; set; }
}
@@ -136,8 +136,8 @@
<!-- Amazon S3 SDK --> <!-- Amazon S3 SDK -->
<ItemGroup> <ItemGroup>
<PackageReference Include="AWSSDK.Extensions.NetCore.Setup" Version="4.0.4.3" /> <PackageReference Include="AWSSDK.Extensions.NetCore.Setup" Version="4.0.4.5" />
<PackageReference Include="AWSSDK.S3" Version="4.0.24" /> <PackageReference Include="AWSSDK.S3" Version="4.0.24.2" />
<ProjectReference Include="..\LiteCharms.Features\LiteCharms.Features.csproj" /> <ProjectReference Include="..\LiteCharms.Features\LiteCharms.Features.csproj" />
<!-- global Usings --> <!-- global Usings -->
@@ -2,8 +2,8 @@
"uat": { "uat": {
"authority": "https://sts.security.khongisa.co.za", "authority": "https://sts.security.khongisa.co.za",
"grantType": "client_credentials", "grantType": "client_credentials",
"clientId": "midrandbooks-api-uat", "clientId": "midrandbooks-api-scaler-uat",
"clientSecret": "secret_5a36d0024980544c875447a4b052938becc3fbbb10b8b2c097310c1a53ba3c0a", "clientSecret": "secret_0a8dc1f99061590a52b1272db3a1871d2761c79fbd058b2a968911029e4b208a",
"scope": "midrandbooks-api" "scope": "midrandbooks-api"
} }
} }
@@ -0,0 +1,3 @@
namespace LiteCharms.Features.Abstractions;
public interface IFeatures;
@@ -9,8 +9,4 @@ public sealed class LiteCharmsSettings
public string? ClientSecret { get; set; } public string? ClientSecret { get; set; }
public string? Audience { get; set; } public string? Audience { get; set; }
public string? RequiredClaimName { get; set; }
public string? RequiredClaimNameValue { get; set; }
} }
@@ -0,0 +1,80 @@
using LiteCharms.Features.Abstractions;
namespace LiteCharms.Features.Browser;
public sealed class LocalStorageService(ProtectedLocalStorage storage) : IService
{
public async ValueTask<Result> DeleteAsync(string key)
{
try
{
await storage.DeleteAsync(key);
return Result.Ok();
}
catch (Exception ex)
{
return Result.Fail(new Error(ex.Message).CausedBy(ex));
}
}
public async ValueTask<Result> SaveAsync(string key, string value)
{
try
{
await storage.SetAsync(key, value);
return Result.Ok();
}
catch (Exception ex)
{
return Result.Fail(new Error(ex.Message).CausedBy(ex));
}
}
public async ValueTask<Result> SaveAsync<TValue>(string key, TValue value) where TValue : class
{
try
{
await storage.SetAsync(key, value);
return Result.Ok();
}
catch (Exception ex)
{
return Result.Fail(new Error(ex.Message).CausedBy(ex));
}
}
public async ValueTask<Result<string>> GetAsync(string key)
{
try
{
var retrieval = await storage.GetAsync<string>(key);
return retrieval.Success && !string.IsNullOrWhiteSpace(retrieval.Value)
? Result.Ok(retrieval.Value)
: Result.Fail($"Could not find object by key {key}");
}
catch (Exception ex)
{
return Result.Fail(new Error(ex.Message).CausedBy(ex));
}
}
public async ValueTask<Result<TValue>> GetAsync<TValue>(string key) where TValue : class
{
try
{
var retrieval = await storage.GetAsync<TValue>(key);
return retrieval.Success && retrieval.Value is not null
? Result.Ok(retrieval.Value)
: Result.Fail($"Could not find object by key {key}");
}
catch (Exception ex)
{
return Result.Fail(new Error(ex.Message).CausedBy(ex));
}
}
}
+32 -27
View File
@@ -10,7 +10,7 @@ public static class Api
public const string Books = nameof(Books); public const string Books = nameof(Books);
public const string Payments = nameof(Payments); public const string Payments = nameof(Payments);
public static IServiceCollection AddLiteCharmsUiSecurity(this IServiceCollection services, IConfiguration configuration) public static IServiceCollection AddLiteCharmsWebSecurity(this IServiceCollection services, IConfiguration configuration)
{ {
var configSection = configuration.GetSection(nameof(LiteCharmsSettings)); var configSection = configuration.GetSection(nameof(LiteCharmsSettings));
@@ -27,13 +27,12 @@ public static class Api
.AddCookie(CookieAuthenticationDefaults.AuthenticationScheme) .AddCookie(CookieAuthenticationDefaults.AuthenticationScheme)
.AddOpenIdConnect(OpenIdConnectDefaults.AuthenticationScheme, options => .AddOpenIdConnect(OpenIdConnectDefaults.AuthenticationScheme, options =>
{ {
options.Authority = authOptions.Authority; options.Authority = authOptions.Authority;
options.ClientId = authOptions.ClientId; options.ClientId = authOptions.ClientId;
options.ClientSecret = authOptions.ClientSecret; options.ClientSecret = authOptions.ClientSecret;
options.SignedOutCallbackPath = "/signout-callback-oidc";
options.ResponseType = "code"; options.ResponseType = "code";
options.SaveTokens = true; options.SaveTokens = true;
options.GetClaimsFromUserInfoEndpoint = true; options.GetClaimsFromUserInfoEndpoint = true;
@@ -42,15 +41,27 @@ public static class Api
options.Scope.Add("profile"); options.Scope.Add("profile");
options.Scope.Add("email"); options.Scope.Add("email");
options.CorrelationCookie.SecurePolicy = CookieSecurePolicy.Always; options.Events = new OpenIdConnectEvents
options.CorrelationCookie.SameSite = SameSiteMode.None; {
options.CorrelationCookie.HttpOnly = true; OnRedirectToIdentityProviderForSignOut = context =>
{
var idToken = context.ProtocolMessage.IdTokenHint;
options.NonceCookie.SecurePolicy = CookieSecurePolicy.Always; if (string.IsNullOrEmpty(idToken))
options.NonceCookie.SameSite = SameSiteMode.None; {
options.NonceCookie.HttpOnly = true; var tokens = context.Properties.GetTokens();
var idTokenItem = tokens.FirstOrDefault(t => string.Equals(t.Name, "id_token", StringComparison.Ordinal));
if (idTokenItem != null) context.ProtocolMessage.IdTokenHint = idTokenItem.Value;
}
return Task.CompletedTask;
},
};
}); });
services.AddCascadingAuthenticationState();
return services; return services;
} }
@@ -76,14 +87,7 @@ public static class Api
}; };
}); });
if (!string.IsNullOrWhiteSpace(authOptions.RequiredClaimName) && !string.IsNullOrWhiteSpace(authOptions.RequiredClaimNameValue)) services.AddAuthorization();
{
services.AddAuthorizationBuilder()
.AddPolicy("RequiredScope", policy =>
policy.RequireClaim(authOptions.RequiredClaimName, authOptions.RequiredClaimNameValue));
}
else
services.AddAuthorization();
return services; return services;
} }
@@ -94,20 +98,21 @@ public static class Api
{ {
await context.ChallengeAsync(OpenIdConnectDefaults.AuthenticationScheme, new AuthenticationProperties await context.ChallengeAsync(OpenIdConnectDefaults.AuthenticationScheme, new AuthenticationProperties
{ {
RedirectUri = redirectUri, RedirectUri = redirectUri,
}); });
}); });
app.MapGet("/logout", async (HttpContext context, IHttpClientFactory httpClientFactory, IOptions<LiteCharmsSettings> settings) => app.MapGet("/logout", async (HttpContext context) =>
{ {
var idToken = await context.GetTokenAsync("id_token");
var authProperties = new AuthenticationProperties { RedirectUri = "/", };
if (!string.IsNullOrEmpty(idToken))
authProperties.Parameters.Add("id_token_hint", idToken);
await context.SignOutAsync(OpenIdConnectDefaults.AuthenticationScheme, authProperties);
await context.SignOutAsync(CookieAuthenticationDefaults.AuthenticationScheme); await context.SignOutAsync(CookieAuthenticationDefaults.AuthenticationScheme);
string currentBaseUrl = $"https://{context.Request.Host}{context.Request.PathBase}/";
await context.SignOutAsync(OpenIdConnectDefaults.AuthenticationScheme, new AuthenticationProperties
{
RedirectUri = currentBaseUrl
});
}); });
return app; return app;
@@ -38,10 +38,10 @@
<PackageReference Include="Microsoft.AspNetCore.Authentication.Certificate" Version="10.0.8" /> <PackageReference Include="Microsoft.AspNetCore.Authentication.Certificate" Version="10.0.8" />
<PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="10.0.8" /> <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="10.0.8" />
<Using Include="Microsoft.AspNetCore.Authentication"/> <Using Include="Microsoft.AspNetCore.Authentication" />
<Using Include="Microsoft.AspNetCore.Authentication.OpenIdConnect"/> <Using Include="Microsoft.AspNetCore.Authentication.OpenIdConnect" />
<Using Include="Microsoft.AspNetCore.Authentication.Cookies"/> <Using Include="Microsoft.AspNetCore.Authentication.Cookies" />
<Using Include="IdentityModel.AspNetCore.OAuth2Introspection"/> <Using Include="IdentityModel.AspNetCore.OAuth2Introspection" />
</ItemGroup> </ItemGroup>
<!-- API Versioning --> <!-- API Versioning -->
@@ -67,7 +67,7 @@
<!-- Quartz Scheduler--> <!-- Quartz Scheduler-->
<ItemGroup> <ItemGroup>
<PackageReference Include="Hashids.net" Version="1.7.0" /> <PackageReference Include="Hashids.net" Version="1.7.0" />
<PackageReference Include="Meziantou.Analyzer" Version="3.0.98"> <PackageReference Include="Meziantou.Analyzer" Version="3.0.102">
<PrivateAssets>all</PrivateAssets> <PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference> </PackageReference>
@@ -171,8 +171,8 @@
<!-- Amazon S3 SDK --> <!-- Amazon S3 SDK -->
<ItemGroup> <ItemGroup>
<PackageReference Include="AWSSDK.Extensions.NetCore.Setup" Version="4.0.4.3" /> <PackageReference Include="AWSSDK.Extensions.NetCore.Setup" Version="4.0.4.5" />
<PackageReference Include="AWSSDK.S3" Version="4.0.24" /> <PackageReference Include="AWSSDK.S3" Version="4.0.24.2" />
<!-- global Usings --> <!-- global Usings -->
<Using Include="Amazon.S3" /> <Using Include="Amazon.S3" />
@@ -182,6 +182,7 @@
<!-- Shared Usings --> <!-- Shared Usings -->
<ItemGroup> <ItemGroup>
<Using Include="Microsoft.AspNetCore.Components.Server.ProtectedBrowserStorage" />
<Using Include="System.Reflection" /> <Using Include="System.Reflection" />
<Using Include="Microsoft.Extensions.DependencyInjection.Extensions" /> <Using Include="Microsoft.Extensions.DependencyInjection.Extensions" />
<Using Include="Microsoft.AspNetCore.Routing" /> <Using Include="Microsoft.AspNetCore.Routing" />