Create Organisation Fix

PostFundManagement.Application/Services/Governance/GovernanceService.cs

@@ -208,9 +208,9 @@ public sealed class GovernanceService(IDbContextFactory<ApplicationDbContext> co
                 linkedUser!.IdNumber = request.IdNumber.Clean();
             }
 
-            var userUpdated = await context.SaveChangesAsync(cancellationToken) > 0;
+            await context.SaveChangesAsync(cancellationToken);
 
-            return Result.OkIf(changedTotal > 0 && updateResult.IsSuccess && userUpdated, UpdateError.Create("Failed to update organisation"));
+            return Result.OkIf(changedTotal > 0 && updateResult.IsSuccess, UpdateError.Create("Failed to update organisation"));
         }));
 
     public async Task<Result> CreatePortfolioAsync(CreatePortfolioRequest request, Guid userId, CancellationToken cancellationToken = default) =>

PostFundManagement.Application/Services/Governance/Records.cs

@@ -1,4 +1,4 @@
-using PostFundManagement.Domain;
+using PostFundManagement.Domain;
 
 namespace PostFundManagement.Application.Services.Governance;
 
@@ -37,7 +37,7 @@ public sealed record UpdateOrganisationRequest([Required] long OrganisationId,
     [Required][MaxLength(LabelLength)] string Name,
     [Required][MaxLength(LabelLength)] string RegistrationNo,
     [Required][EmailAddress][MaxLength(LabelLength)] string Email,
-    [Required][MaxLength(LabelLength)] string IdNumber,
+    [MaxLength(LabelLength)] string? IdNumber,
     [Required] Guid OrganisationUser,
     [Required] OrganisationType Type,
     [Required] ActivityStatus Status);
@@ -45,7 +45,7 @@ public sealed record UpdateOrganisationRequest([Required] long OrganisationId,
 public sealed record CreateOrganisationRequest([Required][MaxLength(LabelLength)] string Name,
     [Required][MaxLength(LabelLength)] string RegistrationNo,
     [Required][EmailAddress][MaxLength(LabelLength)] string Email,
-    [Required][MaxLength(LabelLength)] string IdNumber,
+    [MaxLength(LabelLength)] string? IdNumber,
     [Required] Guid OrganisationUser,
     [Required] OrganisationType Type = OrganisationType.PrivateLimitedCompany);
 

PostFundManagement.Application/Services/Users/UserCacheService.cs

@@ -1,4 +1,4 @@
-using PostFundManagement.Application.Abstractions.Services;
+using PostFundManagement.Application.Abstractions.Services;
 using PostFundManagement.Application.Extensions;
 using PostFundManagement.Application.Services.Shared;
 using PostFundManagement.Domain;
@@ -151,30 +151,7 @@ public sealed class UserCacheService(UserService service, IDistributedCache cach
         }));
 
     public async Task<Result<User[]>> GetUsersAsync(Pagination pagination, UserFilterRequest request, CancellationToken cancellationToken = default) =>
-        await Result.Try((Func<Task<Result<User[]>>>)(async () =>
-        {
-            if (!await featureManager.IsEnabledAsync(ServiceCachingFeature))
-                return await service.GetUsersAsync(pagination, request, cancellationToken);
-
-            var cacheKey = HashService.ToMd5Hash($"getusers-{pagination.Page}-{pagination.PageSize}-" +
-                $"{request.Email}-{request.Status}-{request.SortBy}-{request.SortDescending}").Value;
-
-            var cached = await cache.GetStringAsync(cacheKey, cancellationToken);
-
-            if (string.IsNullOrWhiteSpace(cached))
-            {
-                var usersResult = await service.GetUsersAsync(pagination, request, cancellationToken);
-
-                if (usersResult.IsFailed) return usersResult;
-
-                await cache.SetStringAsync(cacheKey, usersResult.Value.ToJson(),
-                    cacheOptions, cancellationToken);
-
-                return usersResult;
-            }
-
-            return Result.Ok(cached.FromJson<User[]>());
-        }));
+        await service.GetUsersAsync(pagination, request, cancellationToken);
 
     public async Task<Result> LogoutUserAsync(Guid targetUserId, Guid userId, CancellationToken cancellationToken = default) =>
         await service.LogoutUserAsync(targetUserId, userId, cancellationToken);