Improved results handling in service layer

2026-09-11 10:32:51 +02:00
parent 66f720a20b
commit a15b25248d
11 changed files with 87 additions and 103 deletions
@@ -29,16 +29,16 @@ public sealed class TokenService(ISecurityConnectApi connectApi, IOptions<Securi
            {
                var tokenResponse = JsonSerializer.Deserialize<Domain.Security.Models.TokenResponse>(contentRaw);

-                return !string.IsNullOrWhiteSpace(tokenResponse?.AccessToken)
-                    ? Result.Ok(tokenResponse)
-                    : Result.Fail<Domain.Security.Models.TokenResponse>(NotFoundError.Create("Authentication succeeded, but no access token was found in the response payload."));
+                return Result.FailIf(string.IsNullOrWhiteSpace(tokenResponse?.AccessToken),
+                    NotFoundError.Create("Authentication succeeded, but no access token was found in the response payload."))
+                            .ToResult(tokenResponse!);
            }

            return await Result.Try((Func<ValueTask<Result<Domain.Security.Models.TokenResponse>>>)(async () =>
            {
                var errorResult = JsonSerializer.Deserialize<TokenErrorResponse>(contentRaw);

-                return Result.FailIf(errorResult != null,
+                return Result.OkIf(errorResult is not null, 
                    CreateError.Create($"{errorResult!.Error}: {errorResult.ErrorDescription}"));
            }));
        }));