Improved results handling in service layer

2026-09-11 10:32:51 +02:00
parent 66f720a20b
commit a15b25248d
11 changed files with 87 additions and 103 deletions
@@ -38,9 +38,8 @@ public sealed class CommunicationsService(IDbContextFactory<ApplicationDbContext
                CreatedAt = DateTime.UtcNow
            });

-            return await context.SaveChangesAsync(cancellationToken) > 0
-                ? Result.Ok(invite.Map())
-                : Result.Fail<Invite>(CreateError.New);
+            return Result.FailIf(await context.SaveChangesAsync(cancellationToken) <= 0, CreateError.New)
+                .ToResult(invite.Map());
        }));

    public async ValueTask<Result<Invite[]>> GetInvitesAsync(Pagination pagination, CancellationToken cancellationToken = default) =>
@@ -64,9 +63,8 @@ public sealed class CommunicationsService(IDbContextFactory<ApplicationDbContext

            var invite = await context.Invites.AsNoTracking().FirstOrDefaultAsync(i => i.Recipient == applicantUserId, cancellationToken);

-            return invite is not null
-                ? Result.Ok(invite.Map())
-                : Result.Fail<Invite>(NotFoundError.New);
+            return Result.FailIf(invite is null, NotFoundError.New)
+                .ToResult(invite!.Map());
        }));

    public async ValueTask<Result<Invite[]>> GetApplicantInvitesAsync(Guid applicantUserId, CancellationToken cancellationToken = default) =>