RBAC Improvements

Caching improvements
Maker-Checker Implementation

PostFundManagement.ConsoleUI/src/components/monitoring/EvidenceReviewQueue.tsx

@@ -87,7 +87,7 @@ export const EvidenceReviewQueue: React.FC<EvidenceReviewQueueProps> = ({
 }) => {
   const queryClient = useQueryClient();
   const { success, error: toastError } = useToast();
-  const { canAdd, canApprove, canExport } = useRbac();
+  const { canAdd, canApprove, canExport, canApproveRecord, isMaker } = useRbac();
 
   // Filter States: default to initialProjectId if given, otherwise when projects load default to first project
   const [selectedProjectId, setSelectedProjectId] = useState<string | number | 'all'>(initialProjectId);
@@ -824,7 +824,7 @@ export const EvidenceReviewQueue: React.FC<EvidenceReviewQueueProps> = ({
                         </button>
                       )}
 
-                      {canApprove('evidence_risks') && (
+                      {canApproveRecord('evidence_risks', ev.createdBy) && (
                         <button
                           type="button"
                           onClick={() =>
@@ -847,6 +847,11 @@ export const EvidenceReviewQueue: React.FC<EvidenceReviewQueueProps> = ({
                           <span>{ev.status === ApprovalStatus.Approved ? 'Approved' : 'Approve'}</span>
                         </button>
                       )}
+                      {canApprove('evidence_risks') && isMaker(ev.createdBy) && (
+                        <span className="text-[10px] text-amber-400/90 italic font-mono px-1.5 py-0.5 bg-amber-500/10 border border-amber-500/20 rounded-md">
+                          Maker-Checker (Creator)
+                        </span>
+                      )}
 
                       <button
                         type="button"
@@ -1022,7 +1027,7 @@ export const EvidenceReviewQueue: React.FC<EvidenceReviewQueueProps> = ({
                     </button>
                   )}
 
-                  {canApprove('evidence_risks') && (
+                  {canApproveRecord('evidence_risks', inspectEvidence.createdBy) && (
                     <button
                       type="button"
                       onClick={() =>
@@ -1045,6 +1050,12 @@ export const EvidenceReviewQueue: React.FC<EvidenceReviewQueueProps> = ({
                       <span>{reviewMutation.isPending && reviewMutation.variables?.status === ApprovalStatus.Approved ? 'Approving...' : 'Approve Evidence'}</span>
                     </button>
                   )}
+                  {canApprove('evidence_risks') && isMaker(inspectEvidence.createdBy) && (
+                    <span className="text-xs text-amber-400 font-medium px-3 py-1.5 bg-amber-500/10 border border-amber-500/20 rounded-xl flex items-center gap-1.5">
+                      <AlertTriangle className="w-3.5 h-3.5 text-amber-400 shrink-0" />
+                      <span>Maker-Checker Policy: As the creator of this submission, you cannot approve it.</span>
+                    </span>
+                  )}
                 </div>
               </div>
             </div>