Refactored endpoints to be more functional and more expressive

PostFundManagement.Application/Services/Shared/IdentityService.cs

@@ -1,24 +1,20 @@
 using PostFundManagement.Domain;
 using PostFundManagement.Domain.Abstractions;
+using PostFundManagement.Domain.Errors;
 using PostFundManagement.Infrastructure.Database;
 
 namespace PostFundManagement.Application.Services.Shared;
 
 public sealed class IdentityService(IDbContextFactory<ApplicationDbContext> contextFactory) : IService
 {
-    public async ValueTask<Result> UserIsAuthorisedAsync(Guid userId, CancellationToken cancellationToken = default)
-    {
-		try
-		{
-            using var context = await contextFactory.CreateDbContextAsync(cancellationToken);
+    public async ValueTask<Result> UserIsAuthorisedAsync(Guid userId, CancellationToken cancellationToken = default) =>
+        await Result.Try((Func<ValueTask<Result>>)(async () =>
+        {
+            await using var context = await contextFactory.CreateDbContextAsync(cancellationToken);
 
-            return !await context.Users.AnyAsync(u => u.Id == userId && u.Status == ActivityStatus.Active, cancellationToken)
-                ? Result.Fail("Invalid user")
-                : Result.Ok();
-        }
-        catch (Exception ex)
-		{
-            return Result.Fail(new Error(ex.Message).CausedBy(ex));
-        }
-    }
+            var userExistsAndActive = await context.Users
+                .AnyAsync(u => u.Id == userId && u.Status == ActivityStatus.Active, cancellationToken);
+
+            return Result.FailIf(!userExistsAndActive, NotFoundError.Create());
+        }));
 }