Refactored endpoints to be more functional and more expressive

PostFundManagement.Application/Services/Shared/HashService.cs

@@ -1,6 +1,7 @@
 using PostFundManagement.Domain.Abstractions;
+using PostFundManagement.Domain.Errors;
 
-namespace PostFundManagement.Application.Shared;
+namespace PostFundManagement.Application.Services.Shared;
 
 public sealed partial class HashService(IHashids hasher) : IService
 {
@@ -31,59 +32,55 @@ public sealed partial class HashService(IHashids hasher) : IService
     public static Result<string> ToMd5Hash(string input)
     {
         if (string.IsNullOrEmpty(input))
-            return Result.Fail<string>("Input content cannot be null or empty for MD5 processing.");
+            return Result.Fail<string>(ValidationError.Create("Input content cannot be null or empty for MD5 processing."));
 
         byte[] bytes = MD5.HashData(Encoding.UTF8.GetBytes(input));
+
         return Result.Ok(Convert.ToHexString(bytes).ToLowerInvariant());
     }
 
     public Result<string> HashEncodeHex(string input) => string.IsNullOrWhiteSpace(input) || !HexHashRegex.IsMatch(input)
-            ? Result.Fail<string>("Input must be a valid hexadecimal string.")
+            ? Result.Fail<string>(ValidationError.Create("Input must be a valid hexadecimal string."))
             : Result.Ok(hasher.EncodeHex(input));
 
     public Result<string> HashEncodeIntId(int id) => id < 0
-        ? Result.Fail<string>("Id cannot be negative.")
+        ? Result.Fail<string>(ValidationError.Create("Id cannot be negative."))
         : Result.Ok(hasher.Encode(id));
 
     public Result<string> HashEncodeLongId(long id) => id < 0
-        ? Result.Fail<string>("Id cannot be negative.")
+        ? Result.Fail<string>(ValidationError.Create("Id cannot be negative."))
         : Result.Ok(hasher.EncodeLong(id));
 
     public Result<int> DecodeIntIdHash(string hash)
     {
-        if (string.IsNullOrWhiteSpace(hash)) return Result.Fail<int>("Invalid token layout.");
+        if (string.IsNullOrWhiteSpace(hash))
+            return Result.Fail<int>(ValidationError.Create("Invalid token layout."));
 
         int[] decoded = hasher.Decode(hash);
 
-        return decoded.Length == 1 ? Result.Ok(decoded[0]) : Result.Fail<int>("Invalid or modified Int hash token.");
+        return decoded.Length == 1
+            ? Result.Ok(decoded[0]) :
+            Result.Fail<int>(ValidationError.Create("Invalid or modified Int hash token."));
     }
 
     public Result<long> DecodeLongIdHash(string hash)
     {
-        if (string.IsNullOrWhiteSpace(hash)) return Result.Fail<long>("Invalid token layout.");
+        if (string.IsNullOrWhiteSpace(hash))
+            return Result.Fail<long>(ValidationError.Create("Invalid token layout."));
 
         long[] decoded = hasher.DecodeLong(hash);
 
-        return decoded.Length == 1 ? Result.Ok(decoded[0]) : Result.Fail<long>("Invalid or modified Long hash token.");
+        return decoded.Length == 1 ? Result.Ok(decoded[0]) :
+            Result.Fail<long>(ValidationError.Create("Invalid or modified Long hash token."));
     }
 
-    public Result<string> DecodeHexHash(string hex)
-    {
-        try
+    public async Task<Result<string>> DecodeHexHash(string hex) =>
+        await Result.Try((Func<ValueTask<Result<string>>>)(async () =>
         {
             string decoded = hasher.DecodeHex(hex);
 
             return string.IsNullOrEmpty(decoded)
-                ? Result.Fail<string>("Invalid or corrupted hex hash.")
+                ? Result.Fail<string>(ValidationError.Create("Invalid or corrupted hex hash."))
                 : Result.Ok(decoded);
-        }
-        catch (FormatException fex)
-        {
-            return Result.Fail<string>(new Error("Invalid hash structure.").CausedBy(fex));
-        }
-        catch (Exception ex)
-        {
-            return Result.Fail<string>(new Error(ex.Message).CausedBy(ex));
-        }
-    }
+        }));
 }