Implemented missing file handling endpoints

Added contract update endpoint

PostFundManagement.Application/Abstractions/S3ServiceBase.cs

@@ -10,14 +10,55 @@ public abstract class S3ServiceBase(IAmazonS3 amazonS3)
     protected abstract string BucketName { get; }
     protected abstract string CdnBaseUrl { get; }
 
-    public virtual async ValueTask<Result<string>> UploadFileAsync(string fileName, Stream fileStream, string contentType, CancellationToken cancellationToken = default) =>
+    public string GenerateCdnUrl(string fileKey) => $"{CdnBaseUrl}/{fileKey}";
+
+    public virtual async ValueTask<Result<string>> GeneratePresignedUrlAsync(string fileKey, TimeSpan duration, string? contentType = null, CancellationToken cancellationToken = default) =>
         await Result.Try((Func<ValueTask<Result<string>>>)(async () =>
         {
             if (string.IsNullOrWhiteSpace(BucketName))
-                return Result.Fail<string>(Domain.Errors.ValidationError.Create("Bucket name is not configured."));
+                return Result.Fail(ValidationError.Create("Bucket name is not configured."));
+
+            if (string.IsNullOrWhiteSpace(fileKey))
+                return Result.Fail(ValidationError.Create("File key is required."));
+
+            var request = new GetPreSignedUrlRequest
+            {
+                BucketName = BucketName,
+                Key = fileKey,
+                Expires = DateTime.UtcNow.Add(duration),
+                Verb = HttpVerb.GET
+            };
+
+            if (!string.IsNullOrWhiteSpace(contentType))
+            {
+                request.ResponseHeaderOverrides.ContentType = contentType;
+                request.ResponseHeaderOverrides.ContentDisposition = "inline";
+            }
+
+            var presignedUrl = await Client.GetPreSignedURLAsync(request);
+
+            return Result.FailIf(string.IsNullOrWhiteSpace(presignedUrl),
+                CreateError.Create("Failed to create presigned URL"))
+                    .ToResult(presignedUrl);
+        }));
+        
+    private static string CreateFileKey(string path, string fileName, string fileHash)
+    {
+        var cleanSubPath = path.Replace('\\', '/').Trim('/');
+
+        return string.IsNullOrWhiteSpace(cleanSubPath)
+            ? $"{fileHash.ToLower(CultureInfo.InvariantCulture)}_{fileName}"
+            : $"{cleanSubPath}/{fileHash.ToLower(CultureInfo.InvariantCulture)}_{fileName}";
+    }
+
+    public virtual async ValueTask<Result<string>> UploadFileAsync(string fileName, string subPath, Stream fileStream, string contentType, CancellationToken cancellationToken = default) =>
+        await Result.Try((Func<ValueTask<Result<string>>>)(async () =>
+        {
+            if (string.IsNullOrWhiteSpace(BucketName))
+                return Result.Fail<string>(ValidationError.Create("Bucket name is not configured."));
 
             if (string.IsNullOrWhiteSpace(CdnBaseUrl))
-                return Result.Fail<string>(Domain.Errors.ValidationError.Create("CDN base URL is not configured."));
+                return Result.Fail<string>(ValidationError.Create("CDN base URL is not configured."));
 
             await using var stream = new MemoryStream();
 
@@ -31,7 +72,7 @@ public abstract class S3ServiceBase(IAmazonS3 amazonS3)
             if (string.IsNullOrWhiteSpace(fileHash))
                 return Result.Fail<string>(CreateError.Create("Failed to compute file hash."));
 
-            var fileKey = $"{fileHash.ToLower(CultureInfo.InvariantCulture)}{Path.GetExtension(fileName)}";
+            var fileKey = CreateFileKey(subPath, fileName, fileHash);
 
             var putRequest = new PutObjectRequest
             {
@@ -48,7 +89,7 @@ public abstract class S3ServiceBase(IAmazonS3 amazonS3)
 
             return response.HttpStatusCode != HttpStatusCode.OK
                 ? Result.Fail<string>(CreateError.Create($"Failed to upload {fileName} to S3."))
-                : Result.Ok($"{CdnBaseUrl}/{fileKey}");
+                : Result.Ok(fileKey);
         }));
 
     public virtual async ValueTask<Result> DeleteFileAsync(string fileKey, CancellationToken cancellationToken = default) =>
@@ -63,7 +104,7 @@ public abstract class S3ServiceBase(IAmazonS3 amazonS3)
                 Key = fileKey
             }, cancellationToken);
 
-            return Result.FailIf(response.HttpStatusCode == HttpStatusCode.NoContent, 
+            return Result.FailIf(response.HttpStatusCode == HttpStatusCode.NoContent,
                 UpdateError.Create($"Failed to delete {fileKey} from S3."));
         }));
 }

PostFundManagement.Application/Abstractions/Services/IEvidenceService.cs

@@ -27,4 +27,6 @@ public interface IEvidenceService
     ValueTask<Result<Evidence[]>> GetProjectEvidencesAsync(string projectIdHash, CancellationToken cancellationToken = default);
 
     ValueTask<Result> UpdateEvidenceAsync(UpdateEvidenceRequest request, Guid userId, CancellationToken cancellationToken = default);
+
+    ValueTask<Result<string>> GetEvidenceUrlAsync(string evidenceIdHash, CancellationToken cancellationToken = default);
 }

PostFundManagement.Application/Abstractions/Services/IGrantsService.cs

@@ -25,4 +25,10 @@ public interface IGrantsService
     ValueTask<Result> CreateBudgetAsync(CreateBudgetRequest request, Guid userId, CancellationToken cancellationToken = default);
 
     ValueTask<Result> CreateAwardAsync(CreateAwardRequest request, Guid userId, CancellationToken cancellationToken = default);
+
+    ValueTask<Result<string>> GetContractUrlAsync(string contractIdHash, CancellationToken cancellationToken = default);
+    
+    ValueTask<Result> UploadContractAsync(string contractIdHash, Guid userId, IFormFile file, CancellationToken cancellationToken = default);
+    
+    ValueTask<Result> UpdateContractAsync(UpdateContractRequest request, CancellationToken cancellationToken = default);
 }

PostFundManagement.Application/Extensions/S3.cs

@@ -25,40 +25,6 @@ public static class S3
             services.AddKeyedScoped<IS3Service, GeneralS3Service>(GeneralBucketName); 
         }
 
-        if (!string.IsNullOrWhiteSpace(configuration.GetSection($"{EvidenceS3SettingsSection}:ServiceUrl").Value))
-        {
-            services.AddKeyedSingleton<IAmazonS3, AmazonS3Client>(EvidenceBucketName, (provider, client) =>
-                new AmazonS3Client(new BasicAWSCredentials(configuration.GetSection($"{EvidenceS3SettingsSection}:AccessKey").Value,
-                configuration.GetSection($"{EvidenceS3SettingsSection}:SecretKey").Value),
-                new AmazonS3Config
-                {
-                    ServiceURL = configuration.GetSection($"{EvidenceS3SettingsSection}:ServiceUrl").Value,
-                    AuthenticationRegion = configuration.GetSection($"{EvidenceS3SettingsSection}:Region").Value,
-                    ForcePathStyle = true,
-                    EndpointDiscoveryEnabled = true,
-                    UseHttp = configuration.GetSection($"{EvidenceS3SettingsSection}:ServiceUrl").Value!.Contains("http://", StringComparison.InvariantCultureIgnoreCase),
-                }));
-
-            services.AddKeyedScoped<IS3Service, EvidenceS3Service>(EvidenceBucketName);
-        }
-
-        if (!string.IsNullOrWhiteSpace(configuration.GetSection($"{ContractS3SettingsSection}:ServiceUrl").Value))
-        {
-            services.AddKeyedSingleton<IAmazonS3, AmazonS3Client>(ContractBucketName, (provider, client) =>
-                new AmazonS3Client(new BasicAWSCredentials(configuration.GetSection($"{ContractS3SettingsSection}:AccessKey").Value,
-                configuration.GetSection($"{ContractS3SettingsSection}:SecretKey").Value),
-                new AmazonS3Config
-                {
-                    ServiceURL = configuration.GetSection($"{ContractS3SettingsSection}:ServiceUrl").Value,
-                    AuthenticationRegion = configuration.GetSection($"{ContractS3SettingsSection}:Region").Value,
-                    ForcePathStyle = true,
-                    EndpointDiscoveryEnabled = true,
-                    UseHttp = configuration.GetSection($"{ContractS3SettingsSection}:ServiceUrl").Value!.Contains("http://", StringComparison.InvariantCultureIgnoreCase),
-                }));
-
-            services.AddKeyedScoped<IS3Service, ContractS3Service>(ContractBucketName);
-        }
-
         return services;
     }
 }

PostFundManagement.Application/Services/Communications/Records.cs

@@ -3,7 +3,7 @@ using static PostFundManagement.Domain.Extensions.Constants;
 
 namespace PostFundManagement.Application.Services.Communications;
 
-public record InviteRequest([Required] long OrganisationId,
+public sealed record InviteRequest([Required] long OrganisationId,
     [Required] long InvitedOrganisationId,
     [Required] long AwardId,
     [Required] long ContractId,

PostFundManagement.Application/Services/Evidence/EvidenceCacheService.cs

@@ -60,6 +60,27 @@ public sealed class EvidenceCacheService(EvidenceService service, IDistributedCa
             return Result.Ok(cached.FromJson<Domain.Models.Evidence[]>());
         }));
 
+    public async ValueTask<Result<string>> GetEvidenceUrlAsync(string evidenceIdHash, CancellationToken cancellationToken = default) =>
+        await Result.Try((Func<ValueTask<Result<string>>>)(async () =>
+        {
+            var cacheKey = HashService.ToMd5Hash($"getevidenceurl-{evidenceIdHash}").Value;
+
+            var cached = await cache.GetStringAsync(cacheKey, cancellationToken);
+
+            if (string.IsNullOrWhiteSpace(cached))
+            {
+                var result = await service.GetEvidenceUrlAsync(evidenceIdHash, cancellationToken);
+
+                if (result.IsFailed) return result;
+
+                await cache.SetStringAsync(cacheKey, result.Value, cancellationToken);
+
+                return result.Value;
+            }
+
+            return Result.Ok(cached);
+        }));
+
     public async ValueTask<Result<Indicator>> GetIndicatorAsync(string indicatorId, CancellationToken cancellationToken = default) =>
         await Result.Try((Func<ValueTask<Result<Indicator>>>)(async () =>
         {

PostFundManagement.Application/Services/Evidence/EvidenceService.cs

@@ -10,7 +10,7 @@ using PostFundManagement.Infrastructure.Database;
 namespace PostFundManagement.Application.Services.Evidence;
 
 public sealed class EvidenceService(IDbContextFactory<ApplicationDbContext> contextFactory, HashService hashService,
-    [FromKeyedServices(Constants.EvidenceBucketName)] IS3Service s3Service) : IEvidenceService
+    [FromKeyedServices(Constants.GeneralBucketName)] IS3Service s3Service) : IEvidenceService
 {
     public async ValueTask<Result> CreateEvidenceAsync(Guid userId, IFormCollection form, IFormFile file, CancellationToken cancellationToken = default) =>
         await Result.Try((Func<ValueTask<Result>>)(async () =>
@@ -22,13 +22,12 @@ public sealed class EvidenceService(IDbContextFactory<ApplicationDbContext> cont
 
             await using var stream = file.OpenReadStream();
 
-            var uploadResult = await s3Service.UploadFileAsync(file.FileName, stream, file.ContentType, cancellationToken);
+            var uploadResult = await s3Service.UploadFileAsync(file.FileName, "evidence", stream, 
+                file.ContentType, cancellationToken);
 
             if (uploadResult.IsFailed)
                 return Result.Fail(uploadResult.Errors);
 
-            var documentUrl = uploadResult.Value;
-
             await using var context = await contextFactory.CreateDbContextAsync(cancellationToken);
 
             var evidence = new Domain.Entities.Evidence
@@ -41,7 +40,7 @@ public sealed class EvidenceService(IDbContextFactory<ApplicationDbContext> cont
                 CreatedAt = DateTime.UtcNow,
                 Version = 1,
                 Type = type,
-                DocumentUrl = documentUrl,
+                DocumentUrl = uploadResult.Value,
                 Status = ApprovalStatus.Pending
             };
 
@@ -238,4 +237,31 @@ public sealed class EvidenceService(IDbContextFactory<ApplicationDbContext> cont
 
             return Result.OkIf(changedTotal > 0, UpdateError.New);
         }));
+
+    public async ValueTask<Result<string>> GetEvidenceUrlAsync(string evidenceIdHash, CancellationToken cancellationToken = default) =>
+        await Result.Try((Func<ValueTask<Result<string>>>)(async () =>
+        {
+            var decodeResult = hashService.DecodeLongIdHash(evidenceIdHash);
+
+            if (decodeResult.IsFailed)
+                return Result.Fail(IdDecodeError.Create()
+                    .CausedBy(decodeResult.Errors));
+
+            await using var context = await contextFactory.CreateDbContextAsync(cancellationToken);
+
+            var evidence = await context.Evidences.AsNoTracking().FirstOrDefaultAsync(e => e.Id == decodeResult.Value, cancellationToken);
+
+            if (evidence is null)
+                return Result.Fail<string>(NotFoundError.New);
+
+            if (string.IsNullOrWhiteSpace(evidence.DocumentUrl))
+                return Result.Fail<string>(ValidationError.Create("Ecidence is invalid, has no saved documentUrl"));
+
+            var secureDownloadUrlResult = await s3Service.GeneratePresignedUrlAsync(evidence.DocumentUrl, 
+                TimeSpan.FromMinutes(15), null, cancellationToken);
+
+            return Result.OkIf(secureDownloadUrlResult.IsSuccess && !string.IsNullOrWhiteSpace(secureDownloadUrlResult.Value), 
+                NotFoundError.Create("Failed to generate secure file url"))
+                    .ToResult(secureDownloadUrlResult.Value);
+        }));
 }

PostFundManagement.Application/Services/Evidence/Records.cs

@@ -3,19 +3,19 @@ using static PostFundManagement.Domain.Extensions.Constants;
 
 namespace PostFundManagement.Application.Services.Evidence;
 
-public record UpdateEvidenceRequest([Required] long EvidenceId, 
+public sealed record UpdateEvidenceRequest([Required] long EvidenceId, 
     [Required] int Version, 
     [Required] EvidenceType EvidenceType, 
     [Required] ApprovalStatus Status);
 
-public record RecordActualRequest([Required] decimal ActualAmount);
+public sealed record RecordActualRequest([Required] decimal ActualAmount);
 
-public record CreateMilestoneRequest([Required] long ProjectId, 
+public sealed record CreateMilestoneRequest([Required] long ProjectId, 
     [Required] DateTime DueAt, 
     [Required][MaxLength(LabelLength)] string Name, 
     [Required] Priority Priority);
 
-public record CreateIndicatorRequest([Required] long ProjectId, 
+public sealed record CreateIndicatorRequest([Required] long ProjectId, 
     [Required][MaxLength(LabelLength)] string Name, 
     [Required] UnitOfMeasure UnitOfMeasure, 
     [Required] decimal BaselineAmount, 

PostFundManagement.Application/Services/Execution/Records.cs

@@ -3,17 +3,17 @@ using static PostFundManagement.Domain.Extensions.Constants;
 
 namespace PostFundManagement.Application.Services.Execution;
 
-public record UpdateDisbursementRequest([Required] long DisbursementId, long? MilestoneId, [Required] decimal Amount);
+public sealed record UpdateDisbursementRequest([Required] long DisbursementId, long? MilestoneId, [Required] decimal Amount);
 
-public record UpdateRiskRequest([Required] long RiskId,
+public sealed record UpdateRiskRequest([Required] long RiskId,
     [Required] RiskLikelihood Likelihood,
     [Required] RiskImpact Impact,
     [Required][MaxLength(LabelLength)] string Name,
     [Required][MaxLength(TextLength)] string Description);
 
-public record CreateDisbursementRequest([Required] long ProjectId, long? MilestoneId, [Required] decimal Amount);
+public sealed record CreateDisbursementRequest([Required] long ProjectId, long? MilestoneId, [Required] decimal Amount);
 
-public record CreateRiskRequest([Required] long ProjectId,
+public sealed record CreateRiskRequest([Required] long ProjectId,
     [Required] RiskLikelihood Likelihood,
     [Required] RiskImpact Impact,
     [Required][MaxLength(LabelLength)] string Name,

PostFundManagement.Application/Services/Governance/Records.cs

@@ -3,28 +3,28 @@ using static PostFundManagement.Domain.Extensions.Constants;
 
 namespace PostFundManagement.Application.Services.Governance;
 
-public record UpdatePortfolioRequest([Required] long PortfolioId,
+public sealed record UpdatePortfolioRequest([Required] long PortfolioId,
     [Required][MaxLength(LabelLength)] string Name,
     [Required][MaxLength(TextLength)]  string Description, 
     [Required] Guid OwnerId);
 
-public record CreatePortfolioRequest([Required][MaxLength(LabelLength)] string Name,
+public sealed record CreatePortfolioRequest([Required][MaxLength(LabelLength)] string Name,
     [Required][MaxLength(TextLength)] string Description, 
     [Required] long OrganisationId,
     [Required] Guid OwnerId);
 
-public record UpdateOrganisationRequest([Required] long OrganisationId,
+public sealed record UpdateOrganisationRequest([Required] long OrganisationId,
     [Required][MaxLength(LabelLength)] string Name,
     [Required][MaxLength(LabelLength)] string RegistrationNo,
     [Required][EmailAddress][MaxLength(LabelLength)] string Email, 
     [Required] OrganisationType Type);
 
-public record CreateOrganisationRequest([Required][MaxLength(LabelLength)] string Name, 
+public sealed record CreateOrganisationRequest([Required][MaxLength(LabelLength)] string Name, 
     [Required][MaxLength(LabelLength)] string RegistrationNo, 
     [Required][EmailAddress][MaxLength(LabelLength)] string Email, 
     [Required] OrganisationType Type = OrganisationType.PrivateLimitedCompany);
 
-public record Dashboard([Required] decimal PortfolioValue,
+public sealed record Dashboard([Required] decimal PortfolioValue,
     [Required] int ActiveAwards,
     [Required] decimal Disbursed,
     [Required] double OnTrackPercentage,

PostFundManagement.Application/Services/Grants/GrantsCacheService.cs

@@ -146,4 +146,31 @@ public sealed class GrantsCacheService(GrantsService service, IDistributedCache
 
             return Result.Ok(cached.FromJson<Contract[]>());
         }));
+
+    public async ValueTask<Result<string>> GetContractUrlAsync(string contractIdHash, CancellationToken cancellationToken = default) =>
+        await Result.Try((Func<ValueTask<Result<string>>>)(async () =>
+        {
+            var cacheKey = HashService.ToMd5Hash($"getcontracturl-{contractIdHash}").Value;
+
+            var cached = await cache.GetStringAsync(cacheKey, cancellationToken);
+
+            if(string.IsNullOrWhiteSpace(cached))
+            {
+                var result = await service.GetContractUrlAsync(contractIdHash, cancellationToken);
+
+                if(result.IsFailed) return result;
+
+                await cache.SetStringAsync(cacheKey, result.Value, cancellationToken);
+
+                return result.Value;
+            }
+
+            return Result.Ok(cached!);
+        }));
+
+    public async ValueTask<Result> UpdateContractAsync(UpdateContractRequest request, CancellationToken cancellationToken = default) =>
+        await service.UpdateContractAsync(request, cancellationToken);
+
+    public async ValueTask<Result> UploadContractAsync(string contractIdHash, Guid userId, IFormFile file, CancellationToken cancellationToken = default) =>
+        await service.UploadContractAsync(contractIdHash, userId, file, cancellationToken);
 }

PostFundManagement.Application/Services/Grants/GrantsService.cs

@@ -1,6 +1,7 @@
 using PostFundManagement.Application.Abstractions.Services;
 using PostFundManagement.Application.Services.Shared;
 using PostFundManagement.Domain;
+using PostFundManagement.Domain.Abstractions;
 using PostFundManagement.Domain.Errors;
 using PostFundManagement.Domain.Extensions;
 using PostFundManagement.Domain.Models;
@@ -8,7 +9,8 @@ using PostFundManagement.Infrastructure.Database;
 
 namespace PostFundManagement.Application.Services.Grants;
 
-public sealed class GrantsService(IDbContextFactory<ApplicationDbContext> contextFactory, HashService hashService) : IGrantsService
+public sealed class GrantsService(IDbContextFactory<ApplicationDbContext> contextFactory, HashService hashService,
+    [FromKeyedServices(Constants.GeneralBucketName)] IS3Service s3Service) : IGrantsService
 {
     public async ValueTask<Result<Contract[]>> GetContractsAsync(Pagination pagination, CancellationToken cancellationToken = default) =>
         await Result.Try((Func<ValueTask<Result<Contract[]>>>)(async () =>
@@ -201,4 +203,73 @@ public sealed class GrantsService(IDbContextFactory<ApplicationDbContext> contex
 
             return Result.OkIf(await context.SaveChangesAsync(cancellationToken) > 0, CreateError.New);
         }));
+
+    public async ValueTask<Result<string>> GetContractUrlAsync(string contractIdHash, CancellationToken cancellationToken = default) =>
+        await Result.Try((Func<ValueTask<Result<string>>>)(async () =>
+        {
+            var decodeResult = hashService.DecodeLongIdHash(contractIdHash);
+
+            if (decodeResult.IsFailed)
+                return Result.Fail(IdDecodeError.Create()
+                    .CausedBy(decodeResult.Errors));
+
+            await using var context = await contextFactory.CreateDbContextAsync(cancellationToken);
+
+            var contract = await context.Contracts.AsNoTracking().FirstOrDefaultAsync(e => e.Id == decodeResult.Value, cancellationToken);
+
+            if (contract is null)
+                return Result.Fail<string>(NotFoundError.New);
+
+            if (string.IsNullOrWhiteSpace(contract.SignedDocumentUrl))
+                return Result.Fail<string>(ValidationError.Create("Ecidence is invalid, has no saved documentUrl"));
+
+            var secureDownloadUrlResult = await s3Service.GeneratePresignedUrlAsync(contract.SignedDocumentUrl,
+                TimeSpan.FromMinutes(15), null, cancellationToken);
+
+            return Result.OkIf(secureDownloadUrlResult.IsSuccess && !string.IsNullOrWhiteSpace(secureDownloadUrlResult.Value),
+                NotFoundError.Create("Failed to generate secure file url"))
+                    .ToResult(secureDownloadUrlResult.Value);
+        }));
+
+    public async ValueTask<Result> UploadContractAsync(string contractIdHash, Guid userId, IFormFile file, CancellationToken cancellationToken = default) =>
+        await Result.Try((Func<ValueTask<Result>>)(async () =>
+        {
+            var decodeResult = hashService.DecodeLongIdHash(contractIdHash);
+
+            if (decodeResult.IsFailed)
+                return Result.Fail(IdDecodeError.Create()
+                    .CausedBy(decodeResult.Errors));
+
+            await using var stream = file.OpenReadStream();
+
+            var uploadResult = await s3Service.UploadFileAsync(file.FileName, "contracts", stream,
+                file.ContentType, cancellationToken);
+
+            if (uploadResult.IsFailed)
+                return Result.Fail(uploadResult.Errors);
+
+            await using var context = await contextFactory.CreateDbContextAsync(cancellationToken);
+
+            var changedTotal = await context.Contracts.Where(c => c.Id == decodeResult.Value)
+                .ExecuteUpdateAsync(f => f
+                    .SetProperty(c => c.SignedDocumentUrl, uploadResult.Value), cancellationToken);
+
+            var secureDownloadUrlResult = await s3Service.GeneratePresignedUrlAsync(uploadResult.Value,
+                TimeSpan.FromMinutes(15), null, cancellationToken);
+
+            return Result.OkIf(changedTotal > 0 && secureDownloadUrlResult.IsSuccess && !string.IsNullOrWhiteSpace(secureDownloadUrlResult.Value), 
+                CreateError.Create("Failed to upload contract file"));
+        }));
+
+    public async ValueTask<Result> UpdateContractAsync(UpdateContractRequest request, CancellationToken cancellationToken = default) =>
+        await Result.Try((Func<ValueTask<Result>>)(async () =>
+        {
+            await using var context = await contextFactory.CreateDbContextAsync(cancellationToken);
+
+            var changedTotal = await context.Contracts.Where(c => c.Id == request.ContractId)
+                .ExecuteUpdateAsync(f => f
+                    .SetProperty(u => u.Status, request.Status), cancellationToken);
+
+            return Result.OkIf(changedTotal > 0, UpdateError.Create("Failed to update the contract."));
+        }));
 }

PostFundManagement.Application/Services/Grants/Records.cs

@@ -1,18 +1,21 @@
-using static PostFundManagement.Domain.Extensions.Constants;
+using PostFundManagement.Domain;
+using static PostFundManagement.Domain.Extensions.Constants;
 
 namespace PostFundManagement.Application.Services.Grants;
 
-public record CreateAwardRequest([Required] long OrganisationId, [Required] long ProgrammeId, [Required] decimal Amount);
+public sealed record UpdateContractRequest([Required] long ContractId, [Required] ContractStatus Status);
 
-public record CreateBudgetRequest([Required] long ProjectId, 
+public sealed record CreateAwardRequest([Required] long OrganisationId, [Required] long ProgrammeId, [Required] decimal Amount);
+
+public sealed record CreateBudgetRequest([Required] long ProjectId, 
     [Required][MaxLength(LabelLength)] string Name, 
     [Required] decimal Amount);
 
-public record CreateContractRequest([Required] long AwardId, 
+public sealed record CreateContractRequest([Required] long AwardId, 
     [Required] decimal TotalValue, 
     [Required] DateTime EffectiveAt, 
     [Required] DateTime ExpiresAt);
 
-public record ExecuteContractRequest([Required] long ContractId, 
+public sealed record ExecuteContractRequest([Required] long ContractId, 
     [Required][MaxLength(LabelLength)] string ExternalSignatureId, 
     [Required][MaxLength(LabelLength)] string SignedDocumentUrl);

PostFundManagement.Application/Services/Projects/Records.cs

@@ -3,35 +3,35 @@ using static PostFundManagement.Domain.Extensions.Constants;
 
 namespace PostFundManagement.Application.Services.Projects;
 
-public record UpdateProgrammeRequest([Required] long ProgrammeId,
+public sealed record UpdateProgrammeRequest([Required] long ProgrammeId,
     [Required][MaxLength(LabelLength)] string Name, 
     [Required] Guid OwnerId, 
     [Required] ApprovalStatus Status);
 
-public record CreateProgrammeRequest(long PortfolioId, string Name, Guid OwnerId);
+public sealed record CreateProgrammeRequest(long PortfolioId, string Name, Guid OwnerId);
 
-public record UpdateProjectRequest([Required] long ProjectId, 
+public sealed record UpdateProjectRequest([Required] long ProjectId, 
     [Required][MaxLength(LabelLength)] string Name,
     [Required][MaxLength(TextLength)] string Description, 
     DateTime? StartedAt, DateTime? EndedAt, 
     [Required] IndustrySector Sector, 
     [Required] ProjectType ProjectType);
 
-public record UpdateMilestoneRequest([Required] long MilestoneId, 
+public sealed record UpdateMilestoneRequest([Required] long MilestoneId, 
     [Required] DateTime DueAt,
     [Required][MaxLength(LabelLength)] string Name, 
     [Required] Priority Priority, 
     [Required] ApprovalStatus Status);
 
-public record UpdateProjectStatusRequest([Required] long ProjectId, [Required] ApprovalStatus Status);
+public sealed record UpdateProjectStatusRequest([Required] long ProjectId, [Required] ApprovalStatus Status);
 
-public record CreateProjectRequest([Required] long ProgrammeId,
+public sealed record CreateProjectRequest([Required] long ProgrammeId,
     [Required][MaxLength(LabelLength)] string Name,
     [Required][MaxLength(TextLength)] string Description, 
     [Required] IndustrySector Sector, 
     [Required] ProjectType ProjectType);
 
-public record CreateActivityRequest([Required] long ProjectId, 
+public sealed record CreateActivityRequest([Required] long ProjectId, 
     [Required] long? MilestoneId,
     [Required][MaxLength(LabelLength)] string Category, 
     [Required] decimal Amount,

PostFundManagement.Application/Services/Shared/ContractS3Service.cs

@@ -1,12 +0,0 @@
-using PostFundManagement.Application.Abstractions;
-using PostFundManagement.Domain.Abstractions;
-using static PostFundManagement.Domain.Extensions.Constants;
-
-namespace PostFundManagement.Application.Services.Shared;
-
-public sealed class ContractS3Service(IConfiguration configuration, [FromKeyedServices(ContractBucketName)] IAmazonS3 amazonS3) :
-    S3ServiceBase(amazonS3), IS3Service
-{
-    protected override string BucketName => configuration.GetSection($"{ContractS3SettingsSection}:BucketName").Value ?? string.Empty;
-    protected override string CdnBaseUrl => configuration.GetSection($"{ContractS3SettingsSection}:CdnBaseUrl").Value ?? string.Empty;
-}

PostFundManagement.Application/Services/Shared/EvidenceS3Service.cs

@@ -1,12 +0,0 @@
-using PostFundManagement.Application.Abstractions;
-using PostFundManagement.Domain.Abstractions;
-using static PostFundManagement.Domain.Extensions.Constants;
-
-namespace PostFundManagement.Application.Services.Shared;
-
-public sealed class EvidenceS3Service(IConfiguration configuration, [FromKeyedServices(EvidenceBucketName)] IAmazonS3 amazonS3) :
-    S3ServiceBase(amazonS3), IS3Service
-{
-    protected override string BucketName => configuration.GetSection($"{EvidenceS3SettingsSection}:BucketName").Value ?? string.Empty;
-    protected override string CdnBaseUrl => configuration.GetSection($"{EvidenceS3SettingsSection}:CdnBaseUrl").Value ?? string.Empty;
-}

PostFundManagement.Application/Services/Users/Records.cs

@@ -2,4 +2,4 @@
 
 namespace PostFundManagement.Application.Services.Users;
 
-public record UserFilterRequest(ActivityStatus? Status = null, string? Email = null, string? SortBy = null, bool SortDescending = false);
+public sealed record UserFilterRequest(ActivityStatus? Status = null, string? Email = null, string? SortBy = null, bool SortDescending = false);